Repository navigation
🩹 fix: Stub the Attached Route in the Lane Recording Specs - #16840
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Vidminas
added a commit
to Vidminas/plastic-ai
that referenced
this pull request
Oct 9, 2026
Stops before LibreChat-AI#16798, whose ToolService spec uses an undeclared mock (fixed on dev by LibreChat-AI#16840).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolService.spec.jsfails ondevinTests: api (shard 3/3)for every open PR. #16793 added three lane-recording tests that stub the code route withmockResolveCodeExecutionContext, and #16798 merged afterwards and removed that mock when the per-agent code rule moved intoresolveAgentCodeExecution. The tests now throw aReferenceErrorbefore reaching any assertion. The code is correct; only the test setup was stale.The three tests now describe the attached route the way the neighbouring attached-workspace tests do: an attached environment in
statefulCodeSessions.environmentsandcode_environment_idon the agent. Their assertions are unchanged. Lane recording (createLaneGitRecorder) is only wired in the attached-workspace branch ofloadToolsForExecution, which is the route these tests now reach, so no other route needs coverage.Type of change
Testing
Tested environments/configuration: Node 24, jest in
api, no external services.Automated tests:
cd api && npx jest server/services/__tests__/ToolService.spec.js: 158 passed (the three failing tests were reproduced first, all withmockResolveCodeExecutionContext is not defined).npx eslintandnpx prettier --checkon the spec: clean.Screenshots / recordings
Not applicable.
Risk / compatibility
None. Test-only change.
Checklist