Skip to content

馃 fix: Keep System Messages Stable During Collapse #16780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danny-avila merged 1 commit into from
Oct 5, 2026
Merged

馃 fix: Keep System Messages Stable During Collapse #16780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/components/Chat/Messages/Content/Wakeup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ const Wakeup = memo(function Wakeup({
);

return (
<div className={cn('max-w-full', isExpanded && 'w-[36rem]')}>
<div className={cn('max-w-full', shouldRenderBody && 'w-[36rem]')}>
<Button
variant="ghost"
type="button"
Expand Down
59 changes: 59 additions & 0 deletions client/src/components/Chat/Messages/Content/__tests__/Wakeup.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,65 @@ const subagentDisplay = {
};

describe('Wakeup', () => {
it.each([
['subagent', subagentDisplay, 'com_ui_wakeup_subagent_completed'],
[
'background tool',
{
kind: 'background_tool' as const,
tasks: [
{
taskId: 'bg-wide',
status: 'completed' as const,
result: 'wide output '.repeat(200),
toolName: 'bash_tool',
},
],
},
'com_ui_wakeup_task_finished',
],
])('holds the %s width until its closing body unmounts', (_kind, display, label) => {
render(
<ChatSurfaceHarness>
<RecoilRoot>
<Wakeup display={display} conversationId="conversation-1" />
</RecoilRoot>
</ChatSurfaceHarness>,
);

const header = screen.getByRole('button', { name: label });
const panel = screen.getByTestId('wakeup-panel');
const card = header.parentElement;
expect(card).not.toHaveClass('w-[36rem]');
expect(panel).toBeEmptyDOMElement();

fireEvent.click(header);
expect(card).toHaveClass('w-[36rem]');
expect(panel).not.toBeEmptyDOMElement();

fireEvent.click(header);
expect(header).toHaveAttribute('aria-expanded', 'false');
expect(panel).toHaveAttribute('aria-hidden', 'true');
expect(panel.firstElementChild).toHaveAttribute('inert');
expect(card).toHaveClass('w-[36rem]');
expect(panel).not.toBeEmptyDOMElement();

fireEvent.transitionEnd(panel.firstElementChild!);
expect(card).toHaveClass('w-[36rem]');
expect(panel).not.toBeEmptyDOMElement();

fireEvent.click(header);
fireEvent.transitionEnd(panel);
expect(header).toHaveAttribute('aria-expanded', 'true');
expect(card).toHaveClass('w-[36rem]');
expect(panel).not.toBeEmptyDOMElement();

fireEvent.click(header);
fireEvent.transitionEnd(panel);
expect(card).not.toHaveClass('w-[36rem]');
expect(panel).toBeEmptyDOMElement();
});

it('renders a collapsible subagent completion card with the result and panel affordance', () => {
render(
<ChatSurfaceHarness>
Expand Down
Loading