Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/playwright-mock.yml
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,16 @@ jobs:
conversation-management.spec.ts --grep 'first-turn|final-title polling' --reporter=line
--output=e2e/specs/.test-results/title-ownership

- name: Run graph subagent execution regression
if: ${{ !cancelled() && matrix.stream_store == 'memory' && startsWith(matrix.shard, '1/') }}
env:
CI: 'true'
E2E_GRAPH_SUBAGENTS: 'true'
run: >-
npx playwright test --config=e2e/playwright.config.mock.ts
agent-graphs.spec.ts --reporter=line
--output=e2e/specs/.test-results/graph-subagents

- name: Upload title ownership diagnostics
if: ${{ always() && matrix.stream_store == 'memory' && startsWith(matrix.shard, '1/') }}
uses: actions/upload-artifact@v6
Expand Down
3 changes: 2 additions & 1 deletion api/server/controllers/agents/openai.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const {
createOpenAIToolCallStream: createAcceptedToolCallStream,
} = require('@librechat/agents/openai');
const {
hasSubagentCapability,
EModelEndpoint,
ResourceType,
PermissionBits,
Expand Down Expand Up @@ -699,7 +700,7 @@ const executeOpenAIChatCompletion = async (envelope, { req, res }) => {
let handoffAgentConfigs = new Map();
let discoveredEdges = [];
let discoveredMCPAuthMap;
const subagentsCapabilityEnabled = enabledCapabilities.has(AgentCapabilities.subagents);
const subagentsCapabilityEnabled = hasSubagentCapability([...enabledCapabilities]);
const primaryHasGraphSubagents =
subagentsCapabilityEnabled &&
primaryConfig.subagents?.enabled === true &&
Expand Down
3 changes: 2 additions & 1 deletion api/server/controllers/agents/responses.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ const { v4: uuidv4 } = require('uuid');
const { logger } = require('@librechat/data-schemas');
const { Callback, formatAgentMessages } = require('@librechat/agents');
const {
hasSubagentCapability,
EModelEndpoint,
ResourceType,
PermissionBits,
Expand Down Expand Up @@ -952,7 +953,7 @@ const executeResponse = async (envelope, { req, res }) => {
let handoffAgentConfigs = new Map();
let discoveredEdges = [];
let discoveredMCPAuthMap;
const subagentsCapabilityEnabled = enabledCapabilities.has(AgentCapabilities.subagents);
const subagentsCapabilityEnabled = hasSubagentCapability([...enabledCapabilities]);
const primaryHasGraphSubagents =
subagentsCapabilityEnabled &&
primaryConfig.subagents?.enabled === true &&
Expand Down
5 changes: 4 additions & 1 deletion api/server/controllers/agents/v1.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ const {
instructionsContentForScan,
} = require('@librechat/api');
const {
resolveSubagents,
hasSubagentCapability,
Time,
Tools,
SkillsScope,
Expand Down Expand Up @@ -476,7 +478,7 @@ const validateSubagentReferences = async (
const isSubagentsCapabilityEnabled = (req) => {
const capabilities = req.config?.endpoints?.[EModelEndpoint.agents]?.capabilities;
if (!Array.isArray(capabilities)) return false;
return capabilities.includes(AgentCapabilities.subagents);
return hasSubagentCapability(capabilities);
};

const isCodeInterpreterCapabilityEnabled = (req) => {
Expand All @@ -491,6 +493,7 @@ const isCodeInterpreterCapabilityEnabled = (req) => {
* @returns {Promise<{ status: number, body: { error: string, agent_ids: string[] } } | null>}
*/
const getSubagentReferenceError = async (subagents, req, allowedMissingIds = new Set()) => {
subagents = resolveSubagents(subagents, req.config?.endpoints?.agents?.capabilities ?? []);
if (
!isSubagentsCapabilityEnabled(req) ||
subagents?.enabled !== true ||
Expand Down
9 changes: 7 additions & 2 deletions api/server/services/Endpoints/agents/initialize.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ const {
createSubagentCodeRouting,
} = require('@librechat/api');
const {
resolveSubagents,
hasSubagentCapability,
ResourceType,
EModelEndpoint,
PermissionBits,
Expand Down Expand Up @@ -1004,7 +1006,7 @@ const initializeClientWithProvider = async ({
const atSubagentThreadDepthLimit = !subagentThreadTaskStore.canCreateChildThread(
requestConversation?.subagentThread?.depth ?? 0,
);
const subagentsCapabilityEnabled = enabledCapabilities.has(AgentCapabilities.subagents);
const subagentsCapabilityEnabled = hasSubagentCapability([...enabledCapabilities]);
const subagentsAvailableForRun = subagentsCapabilityEnabled && !atSubagentThreadDepthLimit;
/** Track skipped ids locally so repeated failures short-circuit within
* the subagent loading loop. Seeded from the discovery helper's skip
Expand Down Expand Up @@ -1164,6 +1166,7 @@ const initializeClientWithProvider = async ({
getInheritedEnvironments: () => req.codeWorkspaceInheritance,
sharedRunFiles: isRunFileSharingRequested({
policy: appConfig.endpoints?.agents?.fileSharing,
capabilities: [...enabledCapabilities],
agent: primaryConfig,
}),
});
Expand Down Expand Up @@ -1245,7 +1248,7 @@ const initializeClientWithProvider = async ({
memory_scope: agent.memory_scope,
memoryToolsRegistered:
memoryAvailable === true && agent.tools?.includes(Tools.memory) === true,
subagents: agent.subagents,
subagents: resolveSubagents(agent.subagents, [...enabledCapabilities]),
configId: getLazySubagentConfigId(agent),
...codeAvailability,
statefulCodeEnvironment,
Expand Down Expand Up @@ -1410,6 +1413,7 @@ const initializeClientWithProvider = async ({
requestFiles,
authorizedRunFiles: getAuthorizedRunFileSnapshot({
policy: appConfig.endpoints?.agents?.fileSharing,
capabilities: [...enabledCapabilities],
agent: primaryConfig,
files: primaryConfig.currentRequestAttachments,
}),
Expand Down Expand Up @@ -1647,6 +1651,7 @@ const initializeClientWithProvider = async ({
request: runtimeRequestBody,
}),
roots: rootSubagentConfigs.filter((config) => config?.id),
capabilities: [...enabledCapabilities],
loadSubagent: (agentId) => resolveLazyMetadata(() => loadViewableSubagent(agentId)),
environments: statefulCodeSessionsConfig?.environments,
allowEnvironmentSelection: statefulCodeSessionsConfig?.allowEnvironmentSelection,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import React, { useCallback, useMemo } from 'react';
import { Switch } from '@librechat/client';
import { Network, Users } from 'lucide-react';
import { isSubagentGraphsEnabled } from 'librechat-data-provider';
import type { ControllerRenderProps } from 'react-hook-form';
import type { AgentForm } from '~/common';
import { StaticAgentRow, AddAgentSelect, ListMeta, useSelectableAgents } from './AgentList';
Expand Down Expand Up @@ -28,7 +29,7 @@ const AgentSubagents: React.FC<AgentSubagentsProps> = ({
const enabled = value.enabled === true;
const allowSelf = value.allowSelf !== false;
const agentIds = useMemo(() => value.agent_ids ?? [], [value.agent_ids]);
const graphCount = value.graphs?.length ?? 0;
const graphCount = isSubagentGraphsEnabled(value) ? (value.graphs?.length ?? 0) : 0;

const { options, getAgent } = useSelectableAgents({ currentAgentId, exclude: agentIds });

Expand Down Expand Up @@ -106,8 +107,8 @@ const AgentSubagents: React.FC<AgentSubagentsProps> = ({
beta
info={
<>
<p className="text-sm text-text-secondary">{localize('com_ui_agent_subagents_info')}</p>
<p className="text-sm text-text-secondary">{localize('com_ui_agent_subagents_info_2')}</p>
<p className="text-text-secondary text-sm">{localize('com_ui_agent_subagents_info')}</p>
<p className="text-text-secondary text-sm">{localize('com_ui_agent_subagents_info_2')}</p>
</>
}
trailing={
Expand All @@ -126,7 +127,7 @@ const AgentSubagents: React.FC<AgentSubagentsProps> = ({
checked={allowSelf}
onCheckedChange={setAllowSelf}
info={
<p className="text-sm text-text-secondary">
<p className="text-text-secondary text-sm">
{localize('com_ui_agent_subagents_allow_self_info')}
</p>
}
Expand All @@ -139,7 +140,7 @@ const AgentSubagents: React.FC<AgentSubagentsProps> = ({
checked={value.shareFiles === true}
onCheckedChange={setShareFiles}
info={
<p className="text-sm text-text-secondary">
<p className="text-text-secondary text-sm">
{localize('com_ui_agent_subagents_share_files_info')}
</p>
}
Expand Down Expand Up @@ -178,14 +179,14 @@ const AgentSubagents: React.FC<AgentSubagentsProps> = ({
)}

{agentIds.length >= maxSubagents && (
<p className="pt-1 text-center text-xs italic text-text-tertiary">
<p className="text-text-tertiary pt-1 text-center text-xs italic">
{localize('com_ui_agent_subagents_max', { 0: maxSubagents })}
</p>
)}
</div>

{nothingToSpawn && (
<p className="flex items-center gap-2 text-xs italic text-text-warning">
<p className="text-text-warning flex items-center gap-2 text-xs italic">
<Users size={14} aria-hidden="true" />
{localize('com_ui_agent_subagents_empty')}
</p>
Expand Down
Loading
Loading