🪧 fix: Open the Mobile Drawer Below a Site Banner - #16611
Merged
Merged
Conversation
berry-13
marked this pull request as ready for review
October 1, 2026 10:25
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
berry-13
added this pull request to stack #16613
October 1, 2026 10:32
berry-13
force-pushed
the
berry-13/followup-218-banner-over-drawer
branch
from
October 1, 2026 10:32
2f4519e to
d01eeea
Compare
codegraph-librechat
Bot
added
the
🗺️ Chat UI Shell
berry-13
removed this pull request from stack #16613
October 1, 2026 14:02
berry-13
force-pushed
the
berry-13/followup-218-banner-over-drawer
branch
from
October 1, 2026 14:05
d01eeea to
4b28341
Compare
berry-13
added this pull request to stack #16625
October 1, 2026 14:05
berry-13
force-pushed
the
berry-13/followup-218-banner-over-drawer
branch
from
October 1, 2026 15:59
4b28341 to
71c4fdc
Compare
9 tasks done
Base automatically changed from
berry-13/followup-214-new-chat-switch-to-history
to
dev
October 1, 2026 16:39
The drawer was fixed to the viewport, so a configured site banner, which sits above the app and is sticky over it, painted over the drawer's header strip and left its close toggle, panel switcher and New chat untappable. The drawer is now absolute inside the app container, as the scrim and the pane already are, so it opens below the banner. Without a banner the container starts at the top of the screen and nothing moves.
berry-13
force-pushed
the
berry-13/followup-218-banner-over-drawer
branch
from
October 1, 2026 16:39
71c4fdc to
6721ce8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
On a phone, when a deployment configures a site banner, opening the sidebar drawer put its header strip under the banner. The banner sits above the app and is sticky over it, while the drawer was fixed to the top of the viewport, so the banner covered the drawer's close toggle, panel switcher, New chat and account menu. The only way to close the drawer by pointer was to dismiss the banner first, and a persistent banner cannot be dismissed.
The drawer is now positioned inside the app container instead of the viewport, as the scrim and the conversation pane already are, so it opens below the banner and runs to the bottom of the screen. Without a banner the container starts at the top of the screen, so nothing moves.
Fixes berry-13#218. Stacked on #16605, since it changes the drawer in
UnifiedSidebar.tsx, which #16248 owns.Type of change
Testing
Tested environments/configuration:
Automated tests:
e2e/specs/mock/scenarios/mobile-drawer-banner.spec.ts: with a banner, in light and dark, the drawer opens below it and down to the bottom of the screen, and the close toggle, panel switcher and New chat are the elements a tap lands on (the close toggle then closes the drawer); without a banner the drawer still covers the full screen heightnpx jest src/components/UnifiedSidebar(client): 10 suites, 56 tests passreviewctl precheck(ESLint, Prettier, import order, design-rule suppressions, typecheck, related jest): passScreenshots / recordings
Phone width (390px) with a persistent site banner, drawer open. Each pair is before then after, light then dark.
Risk / compatibility
None expected. Without a banner the drawer's geometry is unchanged, since the app container then starts at the top of the screen and is the full width the drawer's 100% and 80% widths were already measured against.
Checklist