fix: remove unsupported macOS codesign flag - #5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a136c792e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Build macOS release | ||
| run: flutter build macos --release --no-codesign --build-name "$BUILD_NAME" --build-number "$BUILD_NUMBER" | ||
| run: flutter build macos --release --build-name "$BUILD_NAME" --build-number "$BUILD_NUMBER" |
There was a problem hiding this comment.
In the macOS release job, removing --no-codesign means Xcode now signs the CI artifact and applies macos/Runner/Release.entitlements; that file only enables com.apple.security.app-sandbox, while the app’s AI providers make outbound http requests (openai_compatible_provider.dart / ollama_provider.dart). Apple documents com.apple.security.network.client as the App Sandbox “Outgoing Connections (Client)” entitlement, so the downloadable macOS release will block configured AI calls unless the release entitlements are completed before signing.
Useful? React with 👍 / 👎.
1 participant
Root cause: Flutter 3.41.9 rejects --no-codesign for flutter build macos, causing run 29160250839 to exit 64. This change removes the flag only from the macOS build; the iOS build remains unchanged with --no-codesign. Verification: git diff --check passed; exact diff contains only the macOS flag removal; macOS and iOS build commands were searched and confirmed.