fix(admin): 후기 CSV 다운로드 Firefox 호환(<a> body 부착 후 클릭)#2428
Merged
Conversation
Gemini 재리뷰 반영: DOM 미부착 <a> 의 click() 이 일부 브라우저에서 무시될 수 있어 document.body 에 추가 후 클릭·제거. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Code Review
이번 풀 리퀘스트에서는 Firefox 등 일부 브라우저에서 DOM에 부착되지 않은 태그의 click() 메서드가 무시되는 현상을 방지하기 위해, 임시로 생성한 링크 엘리먼트를 document.body에 추가한 뒤 클릭 이벤트를 트리거하고 다시 제거하도록 코드를 수정했습니다. 해당 변경 사항에 대해 검토한 결과, 추가적인 피드백은 없습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
배경
PR #2427(후기관리 블로그 CSV·인쇄 전량) 머지 직후 Gemini 리뷰가 남긴 마지막 지적을 반영하는 후속 PR입니다. 해당 지적은 #2427이 이미 머지된 뒤라 그 PR에 담기지 못했습니다.
변경
CSV 다운로드 시 동적 생성한
<a>를document.body에 붙였다 클릭 후 제거.<a>의click()을 무시해 다운로드가 시작되지 않을 수 있음.blogReviewExport.ts3줄 추가(표준 크로스브라우저 패턴).검증
pnpm build:admin통과 /pnpm typecheck:admin변경 파일 신규 에러 0 / ESLint 통과🤖 Generated with Claude Code