Fix and Refactor Roopl Wellformedness checks#1
Merged
Conversation
- Fields are now inherited via a lazy variable - Types for variables are a mutable variable now. Removed TypedVariable/UntypedVariable classes - Added automated tests for four cases
Leridon
force-pushed
the
roopl-wellformedness-fixes
branch
from
f8d95f7 to
4198501
Compare
Leridon
force-pushed
the
roopl-wellformedness-fixes
branch
from
959b0fb to
cf70d8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily fixes a bug that caused inherited fields to not be handled correctly in the Roopl wellformedness checks. To do so, multiple refactors were necessary, including:
inheritFieldsto merge inherited fields into a class does no longer exist.It also adds an initial set of automated tests for Roopl.