Repository navigation
Pass the speed waiver to blurred variants, let Words own its line breaks - #4
Open
ThomasKirst wants to merge 2 commits into
Open
ThomasKirst wants to merge 2 commits into
ThomasKirst wants to merge 2 commits into
Conversation
- deliver.sh: --variant-accept-fast passes the master's --accept-fast range to blurred variants. - Words: render nothing outside its window, so layout-audit.sh stops reporting invisible lines; add breaks for layout-owned line breaks.
This was referenced Oct 17, 2026
Returning null made anything laid out in flow around the line move when it appeared or left. Like MaskRise, the line now keeps its box and carries data-text only while some of it is on screen. Document alignItems for centring broken lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is the second, smaller PR from our film project (the colour fix is in #3). There are two independent things in it. Happy to split them, adjust them or drop either one if it doesn't fit how you see the starter.
Like the first PR, this was made together with Claude (Opus 5.5) in Claude Code.
deliver.sh --variant-accept-fast A-BOur master had a few fast frames that we checked at full size and waived with
render.sh --blur --accept-fast A-B. The blurred variants (--variant-samples) reuse the master's samples, so they hit the same speed gate and stopped before their sub-frame pass.deliver.shhad no way to pass the waiver on.--variant-accept-fast A-Bforwards the range to each variant'srender.sh.--variant-samplesthe flag is refused, since sharp variants have no speed gate.WordsWordsline is invisible but kept itsdata-texttag, solayout-audit.shreported it as overlapping whatever later sat in the same place. We had 27 such false positives, from two copy lines sharing one place across a shot. LikeMaskRise, the line now carriesdata-textonly while some of it is on screen. It keeps its box, so nothing laid out around it moves. (A first version returnednull, which would have shifted neighbours in flow layout; fixed in the second commit.)breaks. Word indices that start a new line. Our 9:16 cuts needed statements on two lines, and it felt cleaner to make the break a layout decision per aspect ([2]in 9:16,[]in 1:1) than to depend on the box width.breaks, the line renders as before, as one row.style={{ alignItems: 'center' }}centres each one.inline-flexcolumn, and thedata-textbox still spans the whole statement.references/copy-and-type.mdandreferences/finishing.mdmention both. TheCHANGELOG.mdentries are under[Unreleased].This PR and the colour PR both add to
[Unreleased]inCHANGELOG.md, so whichever merges second has a small conflict there. I'll rebase this one once the other is in.Checks
lint-film.test.mjspasses.pick.test.pypasses.py_compilepasses for all scripts.bash -n scripts/deliver.shpasses.tsc --noEmitpasses on the starter.layout-audit.shpasses on both variants (0 issues on 44 frames each).