Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
@codex, review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7f2c3c39d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@LeonardNJU 您好，Code Review 提出的最终提交边界格式化、macOS 设置入口及补充平面汉字支持问题均已修复，相关 threads 已 resolved。当前 head 为 |
* Integrate PR #65: src/common/include/vocotype/common/spacing.hpp * Integrate PR #65: src/core/include/vocotype/core/config.hpp * Integrate PR #65: src/core/include/vocotype/core/offline_asr.hpp * Integrate PR #65: src/core/src/config.cpp * Integrate PR #65: src/core/src/dispatcher.cpp * Integrate PR #65: src/core/src/offline_asr.cpp * Integrate PR #65: src/core/src/text_normalizer.cpp * Integrate PR #65: src/core/src/transcription_tasks.cpp * Integrate PR #65: src/core/tests/core_tests.cpp * Integrate PR #65: src/integrations/fcitx5/module/vocotype_module.cpp * Integrate PR #65: src/integrations/macos/VocoTypeApplicationController.mm * Integrate PR #65 Settings toggle * Integrate PR #65 Fcitx setting declaration * Integrate PR #65 changelog * Integrate PR #65 docs
2 participants
中文
在“数字与格式（ITN）”中新增默认关闭的“中文与英文/数字间空格”开关。
使用Claude Code处理2026年数据→使用 Claude Code 处理 2026 年数据。v5.0.8、320m。normalization.space_between_cjk_and_ascii，用于 Core 的最终规整与预览；同时同步 Fcitx5 的最终提交边界，防止 AI 后处理重新挤掉空格。验证：Core 构建及 2 项 CTest 通过；Fcitx5 模块构建通过；
vocotype-settings构建通过；git diff --check通过。English
Add a disabled-by-default “space between CJK and English/numbers” switch to “Numbers and formatting (ITN)”.
使用Claude Code处理2026年数据becomes使用 Claude Code 处理 2026 年数据.v5.0.8and320m.normalization.space_between_cjk_and_ascii, used by Core normalization and preview, and mirrored at the Fcitx5 final-commit boundary so AI post-processing cannot remove the spacing.Validation: Core build and 2 CTests passed; the Fcitx5 module built successfully;
vocotype-settingsbuilt successfully;git diff --checkpassed.