Skip to content

fix(auth): use Header() instead of APIKeyHeader for WS compat #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Leolebleis merged 1 commit into from
May 2, 2026
Merged

fix(auth): use Header() instead of APIKeyHeader for WS compat #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ RUN useradd --create-home appuser
USER appuser
WORKDIR /app

# Pre-create ~/.claude so the named volume inherits appuser ownership when
# Docker first populates it from the image — otherwise the empty mount point
# is root-owned and `claude login` can't write OAuth tokens.
RUN mkdir -p /home/appuser/.claude

COPY --from=builder /app/.venv /app/.venv
COPY --from=frontend-build /app/frontend/dist /app/frontend/dist

Expand Down
9 changes: 4 additions & 5 deletions src/brew/dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
from functools import lru_cache
from typing import Annotated

from fastapi import Depends, HTTPException, Query, Security, status
from fastapi.security import APIKeyHeader
from fastapi import Depends, Header, HTTPException, Query, status

from brew.config import Settings

api_key_header = APIKeyHeader(name="X-API-Key", auto_error=False)


@lru_cache(maxsize=1)
def get_settings() -> Settings:
Expand All @@ -16,7 +13,9 @@ def get_settings() -> Settings:

async def require_api_key(
settings: Annotated[Settings, Depends(get_settings)],
header_key: Annotated[str | None, Security(api_key_header)] = None,
# Header() works on both HTTP and WebSocket routes; fastapi.security.APIKeyHeader
# is HTTP-only — it expects a Request object that WS routes don't provide.
header_key: Annotated[str | None, Header(alias="X-API-Key")] = None,
query_key: Annotated[str | None, Query(alias="api_key")] = None,
) -> None:
if settings.api_key is None:
Expand Down
Loading