-
Notifications
You must be signed in to change notification settings - Fork 0
discovery page #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
discovery page #27
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b067758
discovery page
Lavi2910 ffcee6c
Update apps/web/src/pages/customer/DiscoveryPage/DiscoveryPage.tsx
Lavi2910 ffb83db
Update apps/web/src/pages/customer/DiscoveryPage/components/BusinessC…
Lavi2910 39fec6d
Update apps/web/src/components/layout/AppLayout/styles.ts
Lavi2910 d99f975
ci: trigger pipeline
Lavi2910 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { type CSSProperties } from 'react'; | ||
|
|
||
| export const contentWrapper: CSSProperties = { | ||
| paddingTop: 'calc(0.75rem + env(safe-area-inset-top, 0px))', | ||
| paddingBottom: '5rem', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
apps/web/src/pages/customer/DiscoveryPage/components/SectionHeader/SectionHeader.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| import { theme } from 'antd'; | ||
| import { SolyTypography } from '@soly/ui'; | ||
| import * as styles from './styles'; | ||
|
|
||
| interface SectionHeaderProps { | ||
| title: string; | ||
| onSeeAll?: () => void; | ||
| } | ||
|
|
||
| export const SectionHeader = ({ title, onSeeAll }: SectionHeaderProps) => { | ||
| const { token } = theme.useToken(); | ||
| return ( | ||
| <div style={styles.containerStyle}> | ||
| <SolyTypography variant="pageTitle">{title}</SolyTypography> | ||
| {onSeeAll && ( | ||
| <button | ||
| type="button" | ||
| style={styles.getSeeAllStyle(token)} | ||
| onClick={onSeeAll} | ||
| > | ||
| <SolyTypography variant="captionInherit" color={token.colorPrimary}> | ||
| {'ראה הכל'} | ||
| </SolyTypography> | ||
| </button> | ||
| )} | ||
| </div> | ||
| ); | ||
| }; |
18 changes: 18 additions & 0 deletions
18
apps/web/src/pages/customer/DiscoveryPage/components/SectionHeader/styles.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import type { CSSProperties } from 'react'; | ||
| import type { GlobalToken } from 'antd'; | ||
|
|
||
| export const containerStyle: CSSProperties = { | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| padding: '0 0.75rem', | ||
| }; | ||
|
|
||
| export const getSeeAllStyle = (token: GlobalToken): CSSProperties => ({ | ||
| background: 'none', | ||
| border: 'none', | ||
| padding: 0, | ||
| cursor: 'pointer', | ||
| color: token.colorPrimary, | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The horizontal scroller styles are defined inline in JSX, which makes the component harder to maintain and causes a new style object to be created on every render. Consider extracting this to
DiscoveryPage/styles.ts(similar toCategoryPills’scrollContainerStyle) so it’s reusable and consistent.