Run the pasteable-version check on a schedule, not in the deploy - #2
Open
lr00rl wants to merge 1 commit into
Open
Run the pasteable-version check on a schedule, not in the deploy#2lr00rl wants to merge 1 commit into
lr00rl wants to merge 1 commit into
Conversation
athena built the check and asked where it should be wired; both options were one file, so the reasoning is the deliverable. Not in pages.yml: the drift is caused by an event in ANOTHER repo - a stable release being cut - and this repo receives no push when that happens. A push-triggered check cannot see the failure it exists for; only the schedule can. Wiring it into the deploy would also let an API hiccup block publishing docs, and would surface the failure while someone is shipping something unrelated. Push trigger is kept for the other direction: an edit to the guide that breaks the pin fails immediately rather than up to a day later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires athena's
check-release-pins.mjs, which I verified both directions before writing a line:exit 0today (naming what it compared),exit 1with both versions when the guide is drifted tov0.3.9.Why a scheduled workflow rather than a
pages.ymlstep — the question she asked, and the reasoning is the actual deliverable:lattice-node-agent). This repo receives no push when that happens, so a push-triggered check can never see the failure it exists for. Only the schedule can — which makes the schedule the point, not a belt-and-braces extra.The push trigger is kept for the opposite direction: an edit to the guide that breaks the pin fails immediately instead of up to a day later.
GITHUB_TOKENis passed for the rate limit only; the script runs unauthenticated too.https://claude.ai/code/session_01CoVXeAw726rrKNf8tDLNk1