Make sing-box accounting reach its runtime service alias - #7
Merged
Conversation
sing-box rewrites its generated StatsService descriptor to the V2Ray-compatible service name at runtime. Invoke that alias directly and exercise the same alias in the bufconn regression test so production routing cannot diverge from the test server again. Constraint: Keep the vendored upstream protobuf schema unchanged; only the runtime gRPC method path differs. Rejected: Rewrite the protobuf package | sing-box keeps the experimental message schema and only aliases the registered service name. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep the regression server registered under v2ray.core.app.stats.command.StatsService. Tested: go test -race ./...; go vet ./...; go build ./cmd/lattice-agent; git diff --check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Fixes the alpha sing-box stats collector so it calls the V2Ray-compatible gRPC service name that sing-box actually registers at runtime.
Evidence
Unimplemented: unknown service experimental.v2rayapi.StatsServicev2ray.core.app.stats.command.StatsServicego test -race ./...go vet ./...go build ./cmd/lattice-agentgit diff --checkRelease
Bumps the embedded development version to
0.3.3-alpha.2; publish only as prerelease and keep stablev0.2.9as Latest.