Fix equations in PDF build - #42
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed equation updates address the PDF build compatibility issue without unresolved concerns.
Pull request overview
Updates notebook equations from align to aligned to prevent Sphinx PDF build failures.
Changes:
- Preserves multiline equation alignment.
- Makes equations safely nestable in generated
splitenvironments.
File summaries
| File | Description |
|---|---|
Notebooks/K-space.ipynb |
Fixes MRI signal equation alignment for PDF output. |
Notebooks/In Vivo Contrast Mechanisms.ipynb |
Fixes active and commented contrast equations. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Thanks for the ReviewNB link. No actionable feedback was included in this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDF build now passes GIF conversion but fails when Sphinx nests legacy
alignenvironments inside its generatedsplitenvironment. Replace the affected notebook equations withaligned, which preserves their multi-line alignment while allowing them to be safely nested in display math.Fixes: #37