Convert GIFs for PDF builds - #41
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues remain.
Pull request overview
Updates PDF builds to convert GIFs to static images while preserving animations in HTML.
Changes:
- Enables Sphinx image conversion.
- Adds ImageMagick to build dependencies.
File summaries
| File | Description |
|---|---|
Notebooks/_config.yml |
Enables Sphinx image conversion. |
apt.txt |
Installs ImageMagick for PDF generation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PDF build cannot pass animated GIF files directly to LaTeX, causing the deployment to fail on missing graphic dimensions. Enable Sphinx's ImageMagick converter so GIFs are rendered as static PNG first frames for the PDF while the HTML book retains the original animations.
The workflow image adds the required ImageMagick package, and the book configuration applies the converter to all unsupported images.
Fixes: #37