Repository navigation
[Core] Early draft PR, squad_settings.py in product PRs, decision-check wording - #211
Merged
Merged
Conversation
…k wording Closes #209, closes #210 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018g33ATH7GbPfhTg3cgXiC8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #209, closes #210.
A change with CI-only criteria, a dry run or a Sonar gate that could not run now opens its draft PR right after step 7 (new Early draft PR section in
routing.md); step 9 then also requires green CI, the dry-run result and the Reviewer's round on the same head, and step 10 only posts the record and removesspecs/. A product PR may now change.squad/tools/squad_settings.py(scope-check.py,routing.mdand the seed decision record agree; a fork PR still may not), which resolves the contradiction with Code a unit test cannot cover. The three seeded decision records get- **Area:** —, anddecision-check.pywords the error as "possibly released (release tags unknown …)" when it cannot tell which records are released. Rule files grew by 239 words inrouting.md(+4.6 % over the baseline, below the 15 % consolidation threshold); the step 7 sentence on the Sonar gate was reworded to point to Early draft PR, and nothing else left the rule files.