Repository navigation
[Profile] Pin the .NET formatter in a tool manifest - #205
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018g33ARMh2pXb4p6YkqSbad
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



📖 Description
The
dotnetprofile now seeds a tool manifest.config/dotnet-tools.jsonthat pinsReihitsu.Clianddotnet-sonarscanner, so Dependabot can raise them together withReihitsu.Analyzer. The profile's instructions andstack.mddescribe the formatter as restored withdotnet tool restoreand run asdotnet tool run reihitsu-format, and the SessionStart hook relies on the restore alone instead of installing an unpinned global tool.apply-templatekeeps a repository's own rootdotnet-tools.jsoninstead of seeding a second manifest.core/docs/CONTRIBUTING.mdnow names thefeaturelabel for release notes and notes that the CI run of a first-time contributor's fork waits for a maintainer's approval. The lessons come from the squad run in Censio#3.🎫 Issues
Closes #204
💬 Reviewer Notes
The pinned versions in the seed manifest (
Reihitsu.Cli1.1.0,dotnet-sonarscanner12.0.0) are the latest on NuGet; the CI step that fails when formatter and analyzer leave the same release line is not part of this change.✅ Checklist
python3 tools/template-check.pypasses.ruff check .andpython -m unittest discover toolspass (if Python files changed).core/stays stack- and project-neutral; stack details live inprofiles/<stack>/.README.mdis updated if the layout, a profile or a tool's behaviour changed.🚀 Rollout
Repositories with the
dotnetprofile (PlexToJellyfinSync, Vandox, Censio, DockerUpdateGuard, F1-Telemetry) pick it up with the nextadopt-templaterun.