Skip to content

fix(setup): prevent guided setup exit in default directory#2519

Merged
ToddHebebrand merged 1 commit into
mainfrom
fix/guided-setup-default-directory
Jul 15, 2026
Merged

fix(setup): prevent guided setup exit in default directory#2519
ToddHebebrand merged 1 commit into
mainfrom
fix/guided-setup-default-directory

Conversation

@ToddHebebrand

Copy link
Copy Markdown
Collaborator

Summary

  • return success when Compose project-name preservation intentionally skips the default breeze directory
  • add a regression guard that exercises the real guided-setup function from a directory named breeze
  • run the new guard alongside the existing guided-setup CI check

Root cause

preserve_existing_compose_project_name used a bare return after a false [[ ... ]] condition. For the normal installation directory named breeze, that inherited exit status 1. Because main invokes the function under set -e, guided setup terminated silently immediately after preparing .env.

User impact

Guided setup now continues normally when run from the documented/default breeze directory, regardless of whether the user chooses to back up an existing .env.

Validation

  • bash -n scripts/guided-setup.sh scripts/check-guided-setup-compose-rewrites.sh scripts/check-guided-setup-default-project.sh
  • shellcheck scripts/guided-setup.sh scripts/check-guided-setup-compose-rewrites.sh scripts/check-guided-setup-default-project.sh
  • bash scripts/check-guided-setup-compose-rewrites.sh
  • bash scripts/check-guided-setup-default-project.sh
  • actionlint -shellcheck= .github/workflows/ci.yml
  • git diff --check origin/main...HEAD

@ToddHebebrand
ToddHebebrand marked this pull request as ready for review July 15, 2026 04:46
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying breeze with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1c882fc
Status: ✅  Deploy successful!
Preview URL: https://d2edad28.breeze-9te.pages.dev
Branch Preview URL: https://fix-guided-setup-default-dir.breeze-9te.pages.dev

View logs

@ToddHebebrand
ToddHebebrand merged commit bdb0731 into main Jul 15, 2026
41 checks passed
@ToddHebebrand
ToddHebebrand deleted the fix/guided-setup-default-directory branch July 15, 2026 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant