fix(setup): prevent guided setup exit in default directory#2519
Merged
Conversation
ToddHebebrand
marked this pull request as ready for review
July 15, 2026 04:46
Deploying breeze with
|
| Latest commit: |
1c882fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2edad28.breeze-9te.pages.dev |
| Branch Preview URL: | https://fix-guided-setup-default-dir.breeze-9te.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
breezedirectorybreezeRoot cause
preserve_existing_compose_project_nameused a barereturnafter a false[[ ... ]]condition. For the normal installation directory namedbreeze, that inherited exit status 1. Becausemaininvokes the function underset -e, guided setup terminated silently immediately after preparing.env.User impact
Guided setup now continues normally when run from the documented/default
breezedirectory, regardless of whether the user chooses to back up an existing.env.Validation
bash -n scripts/guided-setup.sh scripts/check-guided-setup-compose-rewrites.sh scripts/check-guided-setup-default-project.shshellcheck scripts/guided-setup.sh scripts/check-guided-setup-compose-rewrites.sh scripts/check-guided-setup-default-project.shbash scripts/check-guided-setup-compose-rewrites.shbash scripts/check-guided-setup-default-project.shactionlint -shellcheck= .github/workflows/ci.ymlgit diff --check origin/main...HEAD