Updated to use PropertyValue method for fixed values / regexes - #33
Open
ptsefton wants to merge 1 commit into
Open
Updated to use PropertyValue method for fixed values / regexes#33ptsefton wants to merge 1 commit into
ptsefton wants to merge 1 commit into
Conversation
| "sh:maxCount": "1", | ||
| "description": "There must with the path `README.html` in the root of the RO-Crate, and it must be described by an entity of type README_Entity with an @id of `README.html`.", | ||
| "value": "README.html" | ||
| "description": "There must with the path `README.html` in the root of the RO-Crate, and it must be described by an entity of type README_Entity with an @id of `README.html`." |
Collaborator
There was a problem hiding this comment.
Sentence doesn't make sense here. And where is the README.html? don't see it in this crate
| { | ||
| "@id": "#property_CreativeWork_README.id", | ||
| "@type": "rdf:Property", | ||
| "description": "README file must have an @id matching /^readme\\.md$/i.", |
Collaborator
There was a problem hiding this comment.
Is the escaped \ here intentional?
| @@ -1,4 +1,4 @@ | |||
| { | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
{ should be kept or the end bracket removed as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the schema and profile to use the new method of handling fixed values (and new regex support - which will change again soon to use shacl props) as per issue 32