fix: JSON password field uses wrong variable (copy-paste bug)#48
Merged
WinterSolstice8 merged 1 commit intoFeb 28, 2026
Merged
Conversation
…N parsing Copy-paste bug on line 570: when using --json mode, g_Password was being set from maybeUsername instead of maybePassword, causing login to always fail because password == username.
WinterSolstice8
approved these changes
Feb 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-line fix for a copy-paste bug in
--jsonmode that causes login to always fail.The Bug
In
main.cppline 570,g_Passwordis set frommaybeUsernameinstead ofmaybePassword:This silently sets the password to the username when using
--jsonmode, so authentication always fails.The Fix
Impact
Anyone using
--jsonmode for automated/launcher login is affected. CLI--user/--passargs are not affected (they use a separate code path).