Skip to content

[login] Support json-based xiloader#7980

Merged
zach2good merged 4 commits into
LandSandBoat:basefrom
WinterSolstice8:login_json
Nov 5, 2025
Merged

[login] Support json-based xiloader#7980
zach2good merged 4 commits into
LandSandBoat:basefrom
WinterSolstice8:login_json

Conversation

@WinterSolstice8

@WinterSolstice8 WinterSolstice8 commented Sep 4, 2025

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Support json-based xiloader
add TOTP for json-based xiloader
This is a breaking change

Requires LandSandBoat/xiloader#39

Steps to test these changes

use all features of new json xiloader

@LandSandBoat LandSandBoat deleted a comment from github-actions Bot Sep 4, 2025
@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 5 times, most recently from cd59e33 to 55bbebf Compare September 11, 2025 02:00
@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 16 times, most recently from 407df68 to 0ac60fb Compare September 17, 2025 15:52
@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 3 times, most recently from f6e0c42 to 9637a36 Compare October 3, 2025 02:26
@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 3 times, most recently from 4ae1125 to f12585e Compare October 22, 2025 04:32
@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 2 times, most recently from 48a5c69 to e777901 Compare October 23, 2025 00:11

@zach2good zach2good left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on this end, when the xiloader side is signed off I'd recommend doing an annoucement a week before you pull the trigger and then merge

Comment thread cmake/FindOpenSSL.cmake
@@ -0,0 +1,12 @@
# this file exists to redirect Module Mode (basic) to OUR libs

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad you figured this out!

@WinterSolstice8

WinterSolstice8 commented Oct 28, 2025

Copy link
Copy Markdown
Contributor Author

I added a commit to this to send a "message of the day" to xiloader
This was true, but was decided to be removed

@WinterSolstice8 WinterSolstice8 force-pushed the login_json branch 4 times, most recently from b455b0e to f2be375 Compare October 28, 2025 14:22
@zach2good zach2good merged commit 9a23a6d into LandSandBoat:base Nov 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants