[C++] [lua] Fix Repair Kit / Mana Tank Interactions#10326
Merged
Xaver-DaRed merged 1 commit intoJun 16, 2026
Merged
Conversation
Fixes the handling of repair kit and mana tank with captures from retail.
Skold177
force-pushed
the
Fix-Repair-Kit-/-Mana-Tank-Interactions
branch
from
e443d2f to
ca9bc14
Compare
Xaver-DaRed
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
This PR fixes how Repair Kit 1-4 and Mana Tank 1-4 are handled for automatons. Previously these were just flat HP Percent / MP Percent mods that we slapped on after spawn. The issue with that is the HP/MP boost these attachments provide is supposed to be reflected in the equipment menu before you even summon them. The other issue is the HP / MP boosts we were giving was static between all frames when it was supposed to be frame specific. So...
Auto Repair Kit 1-4 HP Boost and the Mana Tank 1-4 MP Boost is now calculated in core with a lookup table living in automaton.lua that explains how the HP/MP boost works. Each frame has a divisor that calculates the contribution of the attachment. For example : Auto Repair Kit IV has a value of 4 and the Valoredge frame has a divisor of 24. That means it's HP boost = 4 / 24 = 16.66%~ HP boost. Since these are now calculated core, this also fixes the equipment window showing the HP / MP boost before you summon them.
Updated the puppetmaster equipment menu packet to update every time you switch attachments so this display works properly, before it was only updated when changing frames.
Includes a correction to Stormwaker melee skill, something I discovered I had made a mistake on while testing this PR. Changed from C to C_PLUS.
Side by side comparison of this calculation on retail vs my local
Valoredge with Repair Kit IV
Another spot check
Stormwaker with Repair Kit II and Mana Tank IV
Source
Repair Kit
https://wiki.ffo.jp/html/8619.html
Mana Tank
https://wiki.ffo.jp/html/5330.html
Steps to test these changes
Equip different frames, mix/match various frames/repair kits/mana tanks - see changes reflected in equipment window and HP/MP match retail.