Skip to content

chore: align CLI .version() literals with package.json across 6 packages#72

Merged
LanNguyenSi merged 1 commit into
masterfrom
chore/cli-version-string-sweep-2026-05-11
May 11, 2026
Merged

chore: align CLI .version() literals with package.json across 6 packages#72
LanNguyenSi merged 1 commit into
masterfrom
chore/cli-version-string-sweep-2026-05-11

Conversation

@LanNguyenSi
Copy link
Copy Markdown
Owner

Refs agent-tasks 163a2845-4b05-4c24-83d1-8e4fb36a4e96. Third post-Phase-2 drift cleanup PR; siblings #70 (understanding-gate README) and #71 (debug-playbook-engine canMakeClaim example) already merged.

Why

Six packages hard-coded .version("1.0.0") in their commander entry while package.json was at 0.1.0 or 0.2.0. Every <bin> --version invocation printed a wrong number. Same shape understanding-gate had pre-PR-#70.

What changed

One-character (well, three-character) literal swap per file, no behaviour change. Quote style preserved per file (mix of " and ' across the monorepo, not normalized).

Package package.json was now file:line
claim-gate 0.2.0 "1.0.0" "0.2.0" packages/claim-gate/src/cli.ts:8
debug-playbook-engine 0.1.0 '1.0.0' '0.1.0' packages/debug-playbook-engine/src/index.ts:13
domain-router 0.1.0 '1.0.0' '0.1.0' packages/domain-router/src/index.ts:13
evidence-ledger 0.2.0 "1.0.0" "0.2.0" packages/evidence-ledger/src/cli.ts:24
grounding-wrapper 0.2.0 '1.0.0' '0.2.0' packages/grounding-wrapper/src/index.ts:25
readme-first-resolver 0.1.0 '1.0.0' '0.1.0' packages/readme-first-resolver/src/index.ts:13

Verification

Per touched package, npm test plus npm run typecheck:

Package tests runner typecheck
claim-gate 22 / 22 vitest clean
debug-playbook-engine 21 / 21 jest clean
domain-router 29 / 29 jest clean
evidence-ledger 57 / 57 vitest clean
grounding-wrapper 25 / 25 jest clean
readme-first-resolver 14 / 14 jest clean

Total 168 / 168 green. slop-detector clean on commit message.

Out of scope

  • No package.json version bumps. The fix is "make the CLI agree with the published version", not "cut a release".
  • Recurrence-prevention script (CI check that cli.ts .version() literal matches package.json) was offered as optional in the task description; can be filed as a follow-up if useful.
  • Two pre-existing unused-import diagnostics surfaced by the language server while editing (detectClaimType in claim-gate/src/cli.ts:4, recordStep in debug-playbook-engine/src/index.ts:4, advancePhase in readme-first-resolver/src/index.ts:7). Not introduced by this PR; they were sitting on master. Out of scope for a one-line version fix.

Test plan

  • Review subagent confirms each literal now matches its package's package.json version on master.
  • Reviewer agrees mixing single/double quotes per file (no normalization) is fine.
  • CI green.

Six packages hard-coded .version("1.0.0") in their commander entry,
while their package.json said 0.1.0 or 0.2.0. Every <bin> --version
invocation lied to the user. understanding-gate had the same shape
and was fixed in PR #70; this sweep covers the remaining six.

| Package                 | package.json | was       | now       | file                |
|-------------------------|--------------|-----------|-----------|---------------------|
| claim-gate              | 0.2.0        | "1.0.0"   | "0.2.0"   | src/cli.ts:8        |
| debug-playbook-engine   | 0.1.0        | '1.0.0'   | '0.1.0'   | src/index.ts:13     |
| domain-router           | 0.1.0        | '1.0.0'   | '0.1.0'   | src/index.ts:13     |
| evidence-ledger         | 0.2.0        | "1.0.0"   | "0.2.0"   | src/cli.ts:24       |
| grounding-wrapper       | 0.2.0        | '1.0.0'   | '0.2.0'   | src/index.ts:25     |
| readme-first-resolver   | 0.1.0        | '1.0.0'   | '0.1.0'   | src/index.ts:13     |

Quote style preserved per file (mix of " and ' across the monorepo).

Verification, per touched package:
- claim-gate              22/22 vitest, tsc clean
- debug-playbook-engine   21/21 jest,   tsc clean
- domain-router           29/29 jest,   tsc clean
- evidence-ledger         57/57 vitest, tsc clean
- grounding-wrapper       25/25 jest,   tsc clean
- readme-first-resolver   14/14 jest,   tsc clean

Total 168 / 168 green. No package.json bumps (no release implied).

Refs agent-tasks 163a2845-4b05-4c24-83d1-8e4fb36a4e96.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@LanNguyenSi LanNguyenSi added review:tests-pass merge-approval prereq review:checklist-complete merge-approval prereq review:comments-resolved merge-approval prereq review:scope-matches-task merge-approval prereq review:evidence-logged merge-approval prereq labels May 11, 2026
@LanNguyenSi LanNguyenSi merged commit 904f3e8 into master May 11, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review:checklist-complete merge-approval prereq review:comments-resolved merge-approval prereq review:evidence-logged merge-approval prereq review:scope-matches-task merge-approval prereq review:tests-pass merge-approval prereq

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants