fix: allow re-authenticating an existing account - #120
Open
Bl0ck154 wants to merge 2 commits into
Open
Conversation
Bl0ck154
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #119.
When you try to log in or import an
auth.jsonusing a name that is already in the list, the app now asks before replacing it.If you confirm, it keeps the existing local account entry (including its ID, masking, and timestamps) and replaces the account details and authorization. Cancelling leaves everything untouched. The backend also still rejects duplicates unless the replacement was explicitly confirmed.
I added regression tests for both paths: rejecting an unconfirmed duplicate and refreshing a confirmed ChatGPT account in place.
Testing
pnpm buildcargo fmt --manifest-path src-tauri/Cargo.toml -- --checkcargo testlocally because this Windows environment does not have the MSVC linker (link.exe) installed.