fix: serialize account store updates - #118
Open
demetrius-skypulse wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #100.
Summary
accounts.jsonmutation through one bounded, guard-owned workerfs::writecallsauth.jsonWhy
The Refresh flow launches concurrent metadata and token updates. Each update previously performed its own load-modify-write sequence against
accounts.json, so writes could race and leave valid JSON followed by a stale duplicated suffix. That makes subsequent refreshes fail withFailed to parse accounts file.The same stale-state pattern also allowed an in-flight token refresh to rewrite
~/.codex/auth.jsonfor an account that was no longer active.Scope
This keeps the existing desktop and optional
codex-webentrypoints. Each gets the same single-writer behavior when run independently. Coordinating simultaneous desktop and web processes is intentionally out of scope for this fix.Validation
cargo check --manifest-path src-tauri/Cargo.tomlcargo test --manifest-path src-tauri/Cargo.toml(37 passed)cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets(passes with existing warnings)pnpm buildpnpm tauri build --bundles app --config '{"bundle":{"createUpdaterArtifacts":false}}'git diff --checkNew tests exercise concurrent account updates and confirm mutations execute on the dedicated worker thread.