fix: restore terminal after force closing Codex - #114
Open
ducky-duke wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/devpaths and character devices, open withO_NOCTTY, and skip restoration when a kill partially failspsparsing, TTY path sanitization, and target groupingWhy
Codex enables enhanced CSI-u keyboard reporting while its TUI is active. A
SIGKILLbypasses normal TUI cleanup, so VS Code's terminal can remain in that mode and send encoded key sequences to the restored shell; typing and Enter then appear broken.Validation
cargo test --locked --manifest-path src-tauri/Cargo.toml— 34 passed in a clean Linux container with the Tauri system dependenciescargo fmt --manifest-path src-tauri/Cargo.toml --checkpnpm buildpnpm test:reset-credits— 3 passedgit diff --checkcargo clippy --all-targets -- -D warningscould not run to completion on the host because the WebKitGTK/JavaScriptCoreGTK development packages required by Tauri are not installed. The full Rust test suite compiled and passed in the dependency-complete container.