Skip to content

Fix desktop startup crash on launch#8

Merged
Lakens merged 1 commit into
Lakens:masterfrom
MichelNivard:codex/fix-startup-crash
Mar 15, 2026
Merged

Fix desktop startup crash on launch#8
Lakens merged 1 commit into
Lakens:masterfrom
MichelNivard:codex/fix-startup-crash

Conversation

@MichelNivard

@MichelNivard MichelNivard commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • as noted in [Bug] #7 I had a launch bug, I had codex fix it, it fixed it for me, yoo could/should check it still builds on windows before merging
  • move the editor keyboard-shortcut effect below the callback definitions it depends on to avoid the production startup crash from temporal dead zone access
  • guard WarningBanner against missing editor/current-user data during startup
  • suppress expected unauthenticated /api/user logging noise during desktop startup

Verification

  • npm test --prefix frontend
  • npm run build --prefix frontend
  • npm run build:mac --prefix electron
  • node scripts/electron-smoke.mjs dist/mac-arm64/QuartoReview.app/Contents/MacOS/QuartoReview

@Lakens
Lakens merged commit f457140 into Lakens:master Mar 15, 2026
2 checks passed
@Lakens

Lakens commented Mar 15, 2026

Copy link
Copy Markdown
Owner

will create a new release, v0.0.11 to incorporate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants