Skip to content

Docs/onboarding env webhooks#25

Open
Obiajulu-gif wants to merge 4 commits into
LabsCrypt:mainfrom
Obiajulu-gif:docs/onboarding-env-webhooks
Open

Docs/onboarding env webhooks#25
Obiajulu-gif wants to merge 4 commits into
LabsCrypt:mainfrom
Obiajulu-gif:docs/onboarding-env-webhooks

Conversation

@Obiajulu-gif

Copy link
Copy Markdown
Contributor

Closes #21

@ogazboiz ogazboiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solid docs pass. node version lines up with the dockerfile (node:22-alpine), every required env var in env.ts is now in both the readme table and .env.example, and the schedulers plus the x-remitlend-signature hmac flow are clearly documented. nice touch extracting createWebhookSignature/verifyWebhookSignature with a timing-safe compare, and the deletions only trim aspirational placeholder sections, nothing load-bearing. build, typecheck and the full test suite all pass.

one thing before merge: npx prettier --check . fails on README.md (the markdown tables need prettier's column padding) and it was clean on main, so run npm run format and recommit. once that is green this is good to go.

if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0

@Obiajulu-gif

Copy link
Copy Markdown
Contributor Author

@ogazboiz merge my code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Docs] README understates required env and omits CI, schedulers and webhook security setup

2 participants