add remote.autoConnect and bump stitch-wasm to 0.3.0 - #34
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts
@laboverwire/stitch-wasm0.3.0, which adds theremote.autoConnectoption, and exposes it through the adapter'sRemoteConfig.The autoConnect fix
remote.autoConnect(defaulttrue). WithautoConnect: false,initialize()skips the startup broker connect and the caller drives it viareconnect(url, ticket)— the fix for dynamically-minted-JWT setups where the old ticketless startup probe was rejected once per page load. Defaulttruepreserves existing behavior, so this is additive, non-breaking.Changes
dependencies:@laboverwire/stitch-wasm^0.2.2 → ^0.3.0(0.2→0.3 crosses the caret, so this is a deliberate floor bump).src/types.ts:RemoteConfiggainsautoConnect?: boolean. No adapter code change needed —createStorealready forwards the whole options object to the wasm verbatim, soautoConnectflows through; this only makes it type-safe for consumers.docs/configuration.md: documentsautoConnect.tests/integration/auto-connect.test.ts(2 tests).What the tests verify (behavioral, broker-free)
autoConnect: false+ a bogus remote → afterinitialize(),connectionStatusstays'offline'(no connect attempted),hasRemoteistrue.connectionStatusis not'offline'(a connect was attempted).Verification
tsc,eslint,prettier --checkclean.npm audit= 0.@laboverwire/stitchAPI removal or breaking change; the only surface addition isRemoteConfig.autoConnect.