Repository navigation
wait for crates.io and fail on publish errors in release workflow - #228
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish job ran each
cargo publishwith|| echo "Version already published, skipping"and slept 30s between crates. A real publish failure was hidden, the job went green, and the GitHub Release was still created. And if crates.io had not listed the new mqtt5 within those 30s, the wasm and CLI publishes failed to resolve it and that failure was hidden too.scripts/publish-crate.sh <package>now does each step:cargo publishand lets a failure fail the job, which also stops the GitHub Release (create-releaseneedspublish);cargo publishhas its own 60s wait, but on timeout it only warns, andpublish.timeoutis still unstable.Each index request has a 10s connect and 30s total timeout, and the version is matched as a fixed string.
Tested locally with stand-ins for
cargo(cannot publish) andcurl:.as a regex wildcard is not treated as published;cargo publish, and a failed publish exits 1;The real publish and wait-until-listed path only runs on the next tag.