Repository navigation
apply tls flags to wss urls in cli pub, sub and bench - #218
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mqttv5 pub,subandbenchonly passed--ca-cert,--certand--keyto the client formqtts://,ssl://andquics://URLs. With awss://URL the flags were dropped, so a broker behind a private CA failed withinvalid peer certificate: UnknownIssuereven with the right CA file.The four scheme checks now go through one
uses_tlshelper that includeswss://.cli_wss_tls.rsstarts a WSS broker on the test certs and runspub,sub,bench --mode throughputandbench --mode connectionsagainst it with--ca-cert. All four fail withUnknownIssueron main and pass with this change. Connections mode exits 0 even when every connect fails, so that test checks thefailedcount in the JSON output.