Repository navigation
open one websocket connection per connection attempt - #217
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each resolved address,
MqttClientran a full ws:// or wss:// handshake, but each handshake dials the URL's host on its own and never uses the address it was given. A failed connect tolocalhost, which resolves to::1and127.0.0.1, reached the server twice.WebSocket transports now get one attempt per connect, the same way AWS IoT endpoints already do. TCP, TLS and QUIC still try every resolved address.
tests/client_websocket_dial.rscounts dials against a server that accepts and drops the connection. On main both tests (ws and wss) fail with 2 dials. With this change they pass with 1. The test only discriminates wherelocalhostresolves to more than one address.