Conversation
Contributor
Author
|
Superseded by #176, which includes all four fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four independent defects in the experiment harness and its analysis scripts, all found while preparing an Experiment 2 re-run.
run/applied network impairment to the wrong hostrun/common.shappliednetemviassh_client, whileparallel/common_parallel.shapplies it viassh_broker. The head-of-line blocking experiments measure delivery latency, which travels the broker-to-client path, so impairing the client's egress degrades the publish path instead of the path under measurement. It also throttles ingest: a 60 s run at 500 msg/s recorded 23,590 messages under client-egress loss against 30,001 (the full offered load) under broker-egress loss.run/now matchesparallel/and the documented methodology.Environment variables were silently overridden by the config file
Both harnesses sourced their environment file (
setup/config.env,parallel/group{N}.env) after the caller's environment was in place, soRUNS_PER_DATAPOINT=1 bash run/02c_hol_topic_scaling.shsilently ran the full 15-run sweep. Any key the env file defines behaved the same way. Both now snapshot keys already present in the environment, source the file for defaults, and restore the caller's values, so an explicit setting wins.02c_hol_topic_scaling.shhad drifted from the data it producesThe script specified
--duration 30 --warmup 5 --payload-size 512 --rate 5000, while the results it appends to recordduration 60,payload 256,rate 500— the same operating point as the 8-topic cells it is compared against. Restored, so a re-run extends the existing series instead of silently replacing it with a different condition.Figure loaders crashed on truncated results
fig03_spike_iso_vs_topics.pyandfig14_strategy_comparison.pychecked that a result file existed and then calledjson.loadunguarded, so a single zero-byte file (a run whose broker died, which the harness already reports viawarn_if_empty) aborted figure generation. Both now skip unparseable files with a warning, matching howaggregate.pyhandles the same case.Validated with
bash -nandshellcheck -S erroron the shell changes,ast.parseon the Python, and a behavioural check that an environment override is honoured while the config default still applies when none is given.