Skip to content

QUIC uni-stream QoS 0 skips ack callbacks, flow header 0x14, gzip clippy #169

Description

@fabracht

Smaller defects found during the #164 reviews. All existed before that PR.

  1. QoS 0 on QUIC unidirectional streams never reaches subscribe_with_ack callbacks. Messages on server-opened unidirectional streams are dispatched only to plain subscribe callbacks.
  2. User-defined flow header 0x14 is not recognised on server streams. is_flow_header_byte does not include it, so the header is parsed as MQTT and fails. Since fix MQTT v5 client conformance violations in native and wasm clients #164 a data-stream parse error closes the whole connection, where before it dropped only the stream. No known server sends it.
  3. crates/mqtt5-wasm/src/codec/gzip.rs fails clippy pedantic with --features codec (unnecessary_wraps at line 21, cast_possible_truncation at line 30). CI's wasm clippy does not enable codec, so this is not caught.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions