fix quic partial-frame desync via per-peer writer task - #145
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
send_to_peerused to cancelwrite_allmid-frame (it is not cancellation-safe), leaving a partial length-prefixed frame that the reused stream never resynced from (cluster: a timed-out send leaves a partial frame and desynchronizes the QUIC stream #143)SendStreamand writes one whole frame at a time with no timeout, so a frame is either written whole or the stream is torn downtry_send; a full queue drops the whole frame asSendQueueFullinstead of truncating, and a slow peer can no longer blockbroadcastTest plan
cargo make clippy(pedantic, all feature combos incl.--no-default-features)cargo make test(1201 tests, 0 failures)tests/quic_transport_framing.rspasses on the fix and fails on pre-fix code (verified by reverting onlyquic_transport.rs:assert!(!blocked)fires)Follow-ups
out of scope here, tracked on the #140 mesh/reconnection track: