warn when the cluster peer mesh is incomplete and fix the seed-node docs - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README told users to start each node with a single seed peer, which produces a cluster that fails silently.
docs/distributed-design.mdnow peer every node with all the others and state the requirement next to--peersmqdb cluster statusshows anUNLINKEDline, and the status payload gainedknown_membersandunlinked_nodesThis makes the failure visible, not impossible: a node still cannot dial a peer it was not configured with, because nothing propagates node addresses. Detection also covers a node that was never linked, not a link that dies in flight, since a peer is never removed from the connection map when its stream fails. Both are tracked in #140.
Test plan
cargo make clippypasses with zero warningscargo make test: 24 suites, 1200 passed, 0 failedUNLINKED: [3], node 3 reportsUNLINKED: [2], hub silent, both spokes log the warning withunlinked_nodesdev test --all19/19,dev test --presence7/7