add presence feed to cluster mode via broadcast to all nodes - #138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cluster-mode presence feed, behind the same opt-in
--presence/MQDB_PRESENCEflag as agent mode.$DB/_presence/{client_id}and broadcasts it to every other node, which publishes it locallyTopicTrie::match_topicreturns nothing for$-prefixed topics, so a$DB/_presence/#subscriber can never resolve as a remote target_presenceis added to the$DB/pass-through list so the message reaches subscribers instead of being taken for a database operationmqdb dev test --presencecovering same-node, cross-node both directions, retained state for a late janitor on another node, and a rejected forgeryEvery node ends up holding the retained set, so a janitor sees current state from whichever node it attaches to.
Test plan
cargo make format-checkcleancargo make clippypasses with zero warningscargo make test: 24 suites, 1196 passed, 0 failedmqdb dev test --presence: 7 passed, 0 failed