add opt-in presence feed for client connect and disconnect in agent mode - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Agent-mode presence feed for hold reclaim, off by default.
--presence/MQDB_PRESENCEpublishes retained QoS 0 JSON{client_id, user_id, event, unexpected, ts}to$DB/_presence/{client_id}on connect and disconnectmqdb-clients are skipped$DB/_presence/#is ReadOnly, so clients (admins included) cannot forge presence and a non-admin janitor can subscribe$DB/#handler ignores presence topics$-prefixed topics from wildcard routing, so it will broadcast presence to all nodes insteadTest plan
cargo make format-checkcleancargo make clippypasses with zero warningscargo make test: 24 suites, 1190 passed, 0 failedpresence_test: connect and clean disconnect delivered, retained state reaches a late subscriber, forged publish is not delivered, silent when disabled