add client-facing expected_version compare-and-set on update and delete - #134
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_expected_versionin its payload, and the server rejects the operation if the row's current_versiondiffers.PreconditionFailed(transport code 412), which the write-retry loops treat as non-retryable, distinct from an optimistic-concurrencyConflictthat is retried.update_with_expected/delete_with_expected) and in both cluster write paths (client-dispatched local-primary and forwarded)._expected_versionis stripped before validation and storage, so it never persists as a field; omitting it leaves behavior unchanged. Embedded (WASM) mode ignores it.docs/design/hold-reclaim.md): a janitor reclaims an abandoned hold with a delete guarded on the last-observed version, so a holder that renewed in the meantime is never clobbered.Test plan
cargo make clippy— zero warnings across the workspace and the wasm targetcargo make test— core/agent/vault/cluster suites passcluster_update_delete_expected_version_cascovers both cluster write paths