GitHub Issue 796: JSON logging stopped after Tomcat/Spring update #1265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice hack. Does this still work if there's 3 or more files in play? labkey.org and HSE (audit logs) each get a 3rd file: https://github.com/LabKey/syseng-chef-server/blob/develop/cookbooks/lk_appserver/recipes/default_embedded.rb#L785 |
Contributor
Author
It didn't originally but does now. I tested with three, and it should be fine with whatever number now. We should transition from using the Log4J-style config to the Spring Boot config, but this helps us make the transition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We configure JSON-based Log4J logging via an override file in our cloud instances. This stopped working as of the upgrade to Spring Boot 4.
Changes