Give Troubleshooters read permission in the root #7337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect role/permission streams to a set before serializing to JSON to remove duplicates.
This was referenced Jan 21, 2026
… During role impersonation, filter site roles that aren't available outside the root.
- getSiteRoles() now returns site roles granted to ElevatedUsers but not in the policy, which IMO increases consistency. - Mark User/Group getGroups() as @transient. There's no reason for ObjectFactory to invoke this method. Doing so can end up caching bogus group information, for example, when creating a new group, userId is 0 at the point this is called, thereby caching incorrect groups for Guest user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
TroubleshooterRoledoesn't grant read permissions in the root. This causes multiple problems, particularly viewing admin queries in the root and interacting with those grids. This change gives the role read permission restricted to the root. More details; https://github.com/LabKey/internal-issues/issues/785Separate, but related, many
SecurityPolicymethods iterate roles in a policy associated with a set of principals, populate roles or permissions into a HashSet, and return the set... only for all callers to immediately convert the set to a stream or simply test for the existence of a single role or permission. Reworking these key methods to return Streams provides convenience and avoids creating, populating, discarding, and garbage collecting unnecessary collections, buckets, etc. in these frequently used code paths. It also allows for short-circuiting in the existence cases, since the iteration process can cease as soon as the desired role or permission is seen.