Update TzTimeZone.cs#9
Open
Polyariz wants to merge 1 commit into
Open
Conversation
Issue in ToUniversalTime method:
The method fails to handle DST transition times correctly. When converting local time that falls within the "missing hour" during spring forward transition (e.g. 2:00 -> 3:00), the method throws an ArgumentOutOfRangeException because it can't find a valid rule for that time.
Current behavior:
csharpCopyif (!ZoneRules.Any(z => datetime >= z.StartZone.ToLocalTime() && datetime < z.EndZone.ToLocalTime()))
{
throw new ArgumentOutOfRangeException(nameof(datetime));
}
This check fails for DST transition times. The method should:
Check if time falls within DST transition
If yes, use rule from previous hour
If no, proceed with normal conversion
Example case: Local time 25.03.2023 22:00:00 falls in DST transition but throws exception instead of handling it properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue in ToUniversalTime method:
The method fails to handle DST transition times correctly. When converting local time that falls within the "missing hour" during spring forward transition (e.g. 2:00 -> 3:00), the method throws an ArgumentOutOfRangeException because it can't find a valid rule for that time. Current behavior:
if (!ZoneRules.Any(z => datetime >= z.StartZone.ToLocalTime() && datetime < z.EndZone.ToLocalTime())) {
throw new ArgumentOutOfRangeException(nameof(datetime));
}
This check fails for DST transition times. The method should:
Check if time falls within DST transition
If yes, use rule from previous hour
If no, proceed with normal conversion
Example case: Local time 25.03.2023 22:00:00 (America/Nuuk) falls in DST transition but throws exception instead of handling it properly.