Skip to content

Fix bug where boolean maps weren't translated properly in generate_healpix_map() #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erykoff merged 2 commits into from
Apr 27, 2026
Merged

Fix bug where boolean maps weren't translated properly in generate_healpix_map() #174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ffa608
Add test for converting boolean maps to healpix maps.
erykoff Apr 27, 2026
32e395a
Fix bug so now boolean maps convert properly to healpix maps.
erykoff Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions healsparse/healSparseMap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,8 +1324,8 @@ def generate_healpix_map(self, nside=None, reduction='mean', key=None, nest=True
elif nside > self._nside_sparse:
raise ValueError("Cannot generate HEALPix map with higher resolution than the original.")

# Check to see if we have an integer map.
if issubclass(single_map._sparse_map.dtype.type, np.integer):
# Check to see if we have an integer or boolean map.
if issubclass(single_map._sparse_map.dtype.type, (np.integer, np.bool_, bool)):
dtypeOut = np.float64
else:
dtypeOut = single_map._sparse_map.dtype
Expand Down
35 changes: 35 additions & 0 deletions tests/test_generate_healpix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,41 @@ def test_generate_healpix_map_ring(self):
healpix_map_ring = hp.reorder(healpix_map, n2r=True)
testing.assert_almost_equal(healpix_map_ring, hp_out_ring)

def test_generate_healpix_map_bool(self):
random.seed(seed=12345)

nside_coverage = 32
nside_map = 64

n_rand = 1000
ra = np.random.random(n_rand) * 360.0
dec = np.random.random(n_rand) * 180.0 - 90.0

# Create a HEALPix map
healpix_map = np.zeros(hpg.nside_to_npixel(nside_map), dtype=np.float64) + hpg.UNSEEN
idx = hpg.angle_to_pixel(nside_map, ra, dec)
healpix_map[idx] = 1.0
# Create a HealSparseMap
sparse_map = healsparse.HealSparseMap.make_empty(
nside_coverage=nside_coverage,
nside_sparse=nside_map,
dtype=np.bool_,
)
sparse_map[np.unique(idx)] = True

hp_out = sparse_map.generate_healpix_map(nside=nside_map)
testing.assert_almost_equal(healpix_map, hp_out)

if not has_healpy:
return

# Now check that it works specifying a different resolution
nside_map2 = 32
hp_out = sparse_map.generate_healpix_map(nside=nside_map2)
# Let's compare with the original downgraded
healpix_map = hp.ud_grade(healpix_map, nside_out=nside_map2, order_in='NESTED', order_out='NESTED')
testing.assert_almost_equal(healpix_map, hp_out)


if __name__ == '__main__':
unittest.main()
Loading