Skip to content

issue/591/triaxiality: Build scripts in examples/triaxiality [version:1.18.0]#603

Open
shenmingfu wants to merge 208 commits into
mainfrom
issue/591/triaxiality
Open

issue/591/triaxiality: Build scripts in examples/triaxiality [version:1.18.0]#603
shenmingfu wants to merge 208 commits into
mainfrom
issue/591/triaxiality

Conversation

@shenmingfu
Copy link
Copy Markdown
Collaborator

@shenmingfu shenmingfu commented Jul 18, 2023 •
edited
Loading

@shenmingfu shenmingfu changed the title built a folder examples/triaxiality, added a readme file inside Build scripts in examples/triaxiality Jul 18, 2023
@coveralls
Copy link
Copy Markdown

coveralls commented Jul 18, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same — issue/591/triaxiality into main

@shenmingfu shenmingfu changed the title Build scripts in examples/triaxiality issue/591/triaxiality: Build scripts in examples/triaxiality Jul 18, 2023
@akumgill akumgill self-assigned this Jul 19, 2023
akumgill and others added 19 commits July 19, 2023 14:23
@akumgill
test notebook plotting delta sigma vs radius
5d279b6 
... using equations 31-38 from Tae-hyeon's paper (https://academic.oup.com/mnras/article/475/2/2421/4788804)
@rkrishnan2912
Model predictions for Quadrupole lensing
0a70528
@akumgill
updating notebook with gamma sign and cos term sign
b38d2c6 
... also adding const plots
@akumgill
Merge branch 'issue/591/triaxiality' of https://github.com/LSSTDESC/CLMM
f1d118f 
 into issue/591/triaxiality
@akumgill
code cleanup / removing dupe loops
2b31613
@rancesol
put functions for data analysis into script file
a8c2e32
@rancesol
Merge branch 'issue/591/triaxiality' of https://github.com/LSSTDESC/CLMM
167f3c3 
 into issue/591/triaxiality
@rkrishnan2912
Comparison of two implementations
7e5999d 
Comparison of Tae's and Adhikari's implementations of quadrupole and monopole components
@rancesol
adding fitting files
ae56e5f
@rancesol
Merge branch 'issue/591/triaxiality' of https://github.com/LSSTDESC/CLMM
5461145 
 into issue/591/triaxiality
@rancesol
update fitting notebook
0a020c5
@rancesol
fixed emcee fitting error due to inconcistent parameter values
e742f2a
@rancesol
cleaning up repeated data files
e517e13
@rancesol
update fitting nnotebook to account for corrected monopole term
0ee57e9
@rkrishnan2912
MCMC fitting for elliptical lens model
f2da93b 
Includes fitting for orientation of halo and ellipticity simultaneously.
@rkrishnan2912
Fixed the fitting modules
5fdf268
Added triaxiality theory functions in func_layer.py
54f0299
Merge branch 'issue/591/triaxiality' of https://github.com/LSSTDESC/CLMM
6647498 
 into issue/591/triaxiality
some changes to initialize triaxiality functions
da083fc
combet
combet reviewed May 11, 2026
View reviewed changes
Comment thread clmm/theory/parent_class.py Outdated
combet
combet reviewed May 11, 2026
View reviewed changes
Comment thread examples/demo_dataops_functionality.ipynb Outdated
combet
combet reviewed May 11, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@combet combet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main comment on this PR is to add as much as possible the relevant reference/equation for the new triaxiality parts, either in the docstrings or in the demo notebooks. I commented on the parts I saw, where this could be useful.

@m-aguena
Copy link
Copy Markdown
Member

m-aguena commented May 13, 2026

@combet thanks for the comments, I updated the docstrings with the equations, and added a quick compilation of the documentation page here for you to check out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-aguena m-aguena m-aguena approved these changes

@combet combet combet left review comments

@tae-h-shin tae-h-shin tae-h-shin left review comments

@rancesol rancesol rancesol left review comments

@rkrishnan2912 rkrishnan2912 rkrishnan2912 left review comments

Assignees

@akumgill akumgill

@shenmingfu shenmingfu

@tae-h-shin tae-h-shin

@rancesol rancesol

@rkrishnan2912 rkrishnan2912

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@shenmingfu @coveralls @combet @rancesol @m-aguena @tae-h-shin @rkrishnan2912 @akumgill @ts485