Curved-sky kernels and bin-averaging for angular correlation functions#1296
Open
DhayaaAnbajagane wants to merge 14 commits into
Open
Curved-sky kernels and bin-averaging for angular correlation functions#1296DhayaaAnbajagane wants to merge 14 commits into
DhayaaAnbajagane wants to merge 14 commits into
Conversation
Coverage Report for CI Build 26308510639Coverage increased (+0.002%) to 97.473%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Author
|
With significant help from @junzhou502 , I've now included a benchmark against COCOA, which shows that our curved sky implementation agrees within 1% of COCOA's for various calculations of cosmic shear, GGL, and wtheta. This is the main benchmark we had in mind, and has now been completed on the CCL side. All other standard tests have passed as well. From my vantage, this PR is now ready for review! @carlosggarcia |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CCL currently provides FFTLog, Legendre, and Bessel routines to go from C_ells to two-point angular correlations for spin-0 and spin-2 fields. The Legendre method is the only accurate one for wide-angle curved-sky predictions, where the latter very much matters for DESC analyses. However, this method is currently not implemented for weak lensing, and the one implemented for GG-lensing is quite slow.
This PR does the following:
==============
The API needed some thinking since now we have a theta_min and theta_max. In order to be as non-intrusive as possible, we currently keep the
correlation()function but simply add a new inputtheta_max = None. When it is not None, it is treated as the upper edge of the theta bin, and the existingthetaarg is treated as the lower edge of the bin. Iftheta_maxis not passed, then everything works as usual.The unit tests are still in prep with help from @junzhou502 , but wanted to start this PR so I can at least check if the API is acceptable before I move further.