Generic module to include baryonic effects#1252
Open
sambit-giri wants to merge 5 commits into
Open
Conversation
damonge
requested changes
Jan 13, 2026
Collaborator
damonge
left a comment
There was a problem hiding this comment.
With many apologies for the delay, here's a review.
In addition to the comments below, flake8 is currently failing.
Coverage Report for CI Build 24191658979Coverage decreased (-0.4%) to 97.061%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
…pdate_parameters bug
Author
|
Apologies for the delayed response! I've addressed all the review comments:
Please let me know if anything else needs changing. |
Collaborator
|
@sambit-giri looks great! Could we add one unit test to check that this is doing the right thing? In this case this could be extremely simple (just checking that you recover the arrays you put in when you query the boost factor, for example). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a custom class (
BaryonCustom) to add baryonic effects from any framework. This class takes the suppression or boost data and creates an interpolator.