Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The validation now explains why the in-house Cl differs from XFOIL.
Reference: XFOIL viscous at the real Mach number. For every angle XFOIL runs four times:
dCl total = A - D = num + Mach + visc
Mach and viscosity interact, so their parts are the average of the two orders (Mach first, viscosity first). The split between them can change by up to 0.006 of Cl depending on the order. The sum is exact by construction.
Positive dCl = the in-house solver overestimates Cl.
Other changes:
XFoilAnalysis(viscous=False)for inviscid runs. The default stays viscous, so the optimizers are unchanged.FAILED viscous M0,TIMEOUT ...) instead of always "XFOIL TIMEOUT".validation_plot_cl.svg(Cl vs alpha, in-house / XFOIL inviscid / XFOIL viscous) andvalidation_plot_error.svg(error parts vs alpha), one column per airfoil.Results (Re 3.42e6, Mach 0.147, 160 panels, Windows), alpha = 8 deg
Known limitation
If one of the intermediate XFOIL runs fails, only the total is shown ("breakdown N/A"). On Windows this happened once in 24 cases (NACA 2412, 6 deg, viscous at Mach 0).
Verified
Depends on
#9 (base branch:
feat/xfoil-objective).