Skip to content

ci: add project quality checks#4

Merged
LRriver merged 3 commits into
mainfrom
ci-quality-checks
Jul 8, 2026
Merged

ci: add project quality checks#4
LRriver merged 3 commits into
mainfrom
ci-quality-checks

Conversation

@LRriver

@LRriver LRriver commented Jul 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • add GitHub Actions CI for backend tests/compile, frontend lint/unit/build, and Playwright smoke tests
  • add ESLint flat config so the existing frontend lint script is runnable under ESLint 9
  • remove the direct vite-node devDependency because the declared version is not available from npm and breaks reproducible npm ci installs
  • add CI badges to the English and Chinese READMEs

Local verification

  • npm ci in frontend/
  • python -m pytest -q -> 92 passed, 4 warnings
  • python -m compileall -q backend
  • npm run lint -> 0 errors, 27 warnings from existing frontend any/hook/Fast Refresh rules
  • npm test -- --run -> 25 passed
  • npm run build
  • npm run test:e2e -- interactive-artifacts.spec.ts -> 1 passed
  • git diff --check

Notes

  • Real model/PPT generation is intentionally not a blocking CI check because it depends on local secrets and external model availability.
  • npm audit is intentionally not blocking yet; the current dependency tree reports existing vulnerabilities unrelated to this CI change.

Copilot AI review requested due to automatic review settings July 8, 2026 08:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a CI workflow badge to both the English and Chinese README files, introduces a new ESLint configuration file for the frontend, and removes the unused vite-node dependency from the frontend package configuration. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a GitHub Actions CI pipeline and supporting frontend tooling updates to enforce baseline project quality checks (backend tests/compile, frontend lint/unit/build, and Playwright smoke), while keeping external/secret-dependent checks non-blocking.

Changes:

  • Introduces a CI workflow that runs backend pytest/compileall, frontend lint/unit/build, and a Playwright smoke test, with report upload.
  • Adds an ESLint 9 flat config (eslint.config.js) so the existing npm run lint works under ESLint 9.
  • Removes vite-node from frontend dependencies (previously declared version not available), and adds CI badges to both READMEs.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Adds CI badge pointing to the new workflow.
README_zh.md Adds CI badge pointing to the new workflow.
frontend/package.json Removes vite-node devDependency (nonexistent version).
frontend/package-lock.json Removes vite-node from the lockfile.
frontend/eslint.config.js Adds ESLint 9 flat config for the frontend.
.github/workflows/ci.yml Adds CI workflow for backend + frontend + Playwright smoke tests.
Files not reviewed (1)
  • frontend/package-lock.json: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment on lines +9 to +11
permissions:
contents: read

@LRriver LRriver merged commit 15641de into main Jul 8, 2026
4 checks passed
@LRriver LRriver deleted the ci-quality-checks branch July 8, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants