Repository navigation
Outside contributors: talk about features first, send game profiles to seedds/nxnative first - #439
Merged
Merged
Conversation
…o seedds/nxnative first Fixes stay welcome without asking. A feature, a launcher change or a proposal from outside gets an issue with a maintainer's go before the PR. A new game profile or an engine fix goes to seedds/nxnative first. The maintainers' own rules do not change. PRs opened before keep the old path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
A docs and policy change, waits for @LNPANDY.
What and why
I want to try a friendlier and stricter flow for what comes from outside. New features and proposals get discussed first, so we can help people build what fits, avoid wasted work and conflicts (the launcher code is being reorganized and many open PRs will need a rebase), and agree the design before anyone writes code. Fixes stay welcome without asking. Everything here is about outside contributors. We maintainers keep our own rules.
This changes what @LNPANDY and I agreed on 2026-10-31 for outside feature PRs (PR first, issue within 48 hours). @LNPANDY decides.
What changes:
An idea) or Discussions, Ideas. The discussion ends when a maintainer says yes and puts the issue into a milestone. An issue in a milestone is the go, no label is needed, and the PR links it. A feature PR without it is not reviewed and is closed with a friendly note after 14 days, it can be reopened. A draft PR as a sketch is fine but waits for the go. For a change across several front ends or the architecture, the issue also holds a short design note (what, why, alternatives). If it is unclear whether something is a fix, the contributor asks in an issue and the maintainers decide. An earlier version of this PR had small, medium and large tiers with an exemption list. That is dropped.dm/games/<id>/). "Helping with games" now says: send a new profile or an engine fix to seedds/nxnative first, following their CONTRIBUTING.md, and link it in a Game problem issue here. A report that a game works stays welcome and becomes a GAMES.md entry. When upstream is slow and the game is verified here, a maintainer may bridge it as a patch (Upstream-Status: forwarded) and sends the upstream PR if the contributor cannot.config.yml: the nxnative contact link says the profile goes there as a PR..github/copilot-instructions.mdand the "For AI agents" list: check for an issue in a milestone before building a feature for an outside contributor, and send a profile to seedds/nxnative first. AGENTS.md "Here first, upstream in parallel" only gets one sentence: outside contributors start upstream.Trade-offs:
How seedds/nxnative wants it: their CONTRIBUTING.md asks for one change per PR off
main, a new game takes its profile, its note and its row in the games table, and an issue first for large changes. The maintainer often takes a PR in as a reworked commit withCo-authored-byand closes it.Suggestion, not built: a check in
pr-scope.ymlthat comments on a feature PR without a linked issue.It would need a way to tell a feature from a fix, so I left it out for now.
Checked
Screenshots
None, no visible change.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is open