Repository navigation
Patch 0046: a multi-program game's Mac host compiles again (#1145) - #1250
Open
Haseenesss wants to merge 1 commit into
Open
Haseenesss wants to merge 1 commit into
Haseenesss wants to merge 1 commit into
Conversation
) Patch 0017 builds the Mac preferences domain by joining @"org.nxnative." and DM_GAME_ID as string literals. A multi-program profile such as Super Mario 3D All-Stars defines DM_GAME_ID at run time, so its Mac host did not compile. The new patch boxes the ID at run time, as seedds/nxnative#221's branch already does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Problem. The Mac host of Super Mario 3D All-Stars (010049900F546000) does not compile. Fixes #1145.
Cause. Patch 0017 joins
@"org.nxnative."andDM_GAME_IDas string literals. A multi-program profile definesDM_GAME_IDat run time.Change. New patch 0046 boxes the ID at run time:
[@"org.nxnative." stringByAppendingString:@(DM_GAME_ID)].Upstream: seedds/nxnative#221's branch already has this line. Patch 0017 was adapted from an older commit of it, so no new upstream PR is needed. The patch says
forwarded seedds/nxnative#221and goes when #221 merges.Checked
python3 tools/engine.py check(45 patches apply).main.clinked to reachdm_game_cur. Compile checks instead, below.Details
With
gen/<id>/game_profile.hgenerated bymake -C dm/host gen/<id>/game_profile.h:front_mac.msyntax, beforefront_mac.msyntax, aftercontrollers_mac.msyntax, before → aftermake -C dm/host/tests build/t_controllers_mac, afterdm_game_curScreenshots
None, no visible change.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is open🤖 Generated with Claude Code